Maniphest T8446

Kleopatra: Pressing Enter when "Show Audit Log" button has focus unexpectedly triggers "Save All" button
Testing, NormalPublic
Actions

Assigned To
• ikloecker
Authored By
• ikloecker
Wed, Sep 9, 10:44 AM
Tags
Subscribers
• ebo
• ikloecker

Description

After successful decryption the window showing the result has a "Save All" button and (usually) a "Show Audit Log" button for the decryption.

Press Tab until the "Show Audit Log" button has focus. Then press Enter.

Expected result:
Nothing happens. (Ideally Enter would trigger the focused button, but that's out of scope of this ticket. See T6110: Kleopatra: All buttons shall be activatable with the Enter/Return key.)

Actual result:
Save All is triggered.

The screenshot shows that the "Show Audit Log" button has the focus frame but the "Save All" button is painted as default button. Pressing Space triggers the former button while pressing Enter triggers the latter.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA516c0d236738 Only change visibility of Audit Log button if necessary
rKLEOPATRA55a0719aae5f Counter styles messing with autodefault property of push buttons
rKLEOPATRAd30618d5f5c6 Prevent accidental triggering of "Save All" button
rKLEOPATRA5ce1a3736725 Only change visibility of Audit Log button if necessary
rKLEOPATRAc3195c41f97e Counter styles messing with autodefault property of push buttons
rKLEOPATRAd14eb2f2a308 Prevent accidental triggering of "Save All" button

Related Objects

Event Timeline

• ikloecker triaged this task as Normal priority.Wed, Sep 9, 10:44 AM
• ikloecker created this task.
• ikloecker updated the task description. (Show Details)Wed, Sep 9, 12:12 PM
• ikloecker added a commit: rKLEOPATRAd14eb2f2a308: Prevent accidental triggering of "Save All" button.Wed, Sep 9, 12:20 PM
• ikloecker changed the task status from Open to Testing.EditedWed, Sep 9, 2:01 PM
• ikloecker moved this task from Backlog to WIP on the gpd5x board.

Fixed by making sure that "Save All" is never the default button.

The downside of this fix is that one cannot simply press Enter anymore to save the results. Instead one has to focus the Save All button and then press Space. (One can also use the shortcut Alt+S.)

• ikloecker changed the task status from Testing to Open.Wed, Sep 9, 5:23 PM

I'm working on a better fix which avoids the downside as much as reasonable.

• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Sep 14, 10:00 AM
• ikloecker added a commit: rKLEOPATRAc3195c41f97e: Counter styles messing with autodefault property of push buttons.Tue, Sep 15, 2:46 PM
• ikloecker added a commit: rKLEOPATRA5ce1a3736725: Only change visibility of Audit Log button if necessary.
• ikloecker added a commit: rKLEOPATRAd30618d5f5c6: Prevent accidental triggering of "Save All" button.Tue, Sep 15, 4:20 PM
• ikloecker added a commit: rKLEOPATRA55a0719aae5f: Counter styles messing with autodefault property of push buttons.
• ikloecker added a commit: rKLEOPATRA516c0d236738: Only change visibility of Audit Log button if necessary.
• ikloecker changed the task status from Open to Testing.Tue, Sep 15, 4:40 PM

I found a better solution. The "Select Folder" button, the "Show Audit Log" button, and the info button can now be pressed with Enter (and Space) just as "Save All". If the folder input field or the result message (but not the link in the result message) has keyboard focus then Enter triggers the "Save All" button, i.e. people can quickly complete the decryption by pressing Enter (unless another UI element which reacts on Enter has focus).

• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Oct 5, 9:18 AM
• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Oct 5, 9:58 AM