Maniphest T8440

gpgol/web: Crash on sending/autosaving empty message
Open, HighPublic
Actions

Assigned To
tfry
Authored By
tfry
Fri, Sep 4, 12:40 PM
Tags
Subscribers
tfry

Description

  • Compose a new message
  • optionally address the message to yourself, but leave everything else empty
  • Click send OR wait for autosave to kick in

-> crash

Related Objects

Event Timeline

tfry triaged this task as High priority.Fri, Sep 4, 12:40 PM
tfry created this task.
tfry mentioned this in rOJe2b8fc93c159: Unify and fix handling of empty messages.Fri, Sep 4, 12:43 PM
tfry moved this task from Backlog to Review on the gpgol2 board.Fri, Sep 4, 12:50 PM

See commit for a tentative fix.

Alternatively, we could abort on empty message in ComposerViewBase, but there the situation may be less clear-cut (think attachments, recipients), and a check would need to be added on each of save draft, autosave, send.

I feel a bit unsure due to the differences/inconsistency in the handling in the existing code base (see diff). I unified that, but hope I did not overlook anything.