Kleopatra: Open certificate details in "Edit Group" dialog on pressing Enter
Testing, NormalPublic

Assigned To
Authored By
timegrid
Mon, Aug 31, 12:00 PM

Description

In the certificate lists of "Edit Group" the certificate details should be opened, when Enter is pressed
(like in T7752: Create default Shortcut for details for the main certificate list):

Currently it works only via mouse doubleclick.
There is no entry in the context menu:

Details

Version
vsd-3.4.0-beta1344 @ win10 / vsd-4.0.0-beta1330 @ win10

Event Timeline

timegrid created this object with edit policy "Contributor (Project)".

I'm not sure whether we want to use Enter here. The fix is trivial, but there are quite a few dialog showing a certificate list where pressing Enter has a different effect, e.g. the server lookup does Import on Enter and the details dialog does Update (even if the certifications tab is shown where double click opens the details of the certifying key). Using Enter as shortcut might have been a bad idea in general because it doesn't work everywhere.

In the "Edit Group" dialog I'm wondering if it wouldn't be much more convenient if Enter moved the key to the other list. And I've been pondering the same for double click, by the way. The primary action in this dialog is to move keys from the available list to the group list and occasionally vice-versa. Consequently, this action should be as easy as possible. Using Enter for keyboard users and double click for mouse users seems like an obvious choice. (Most mouse users will likely also expect drag&drop which also doesn't work but that's yet another story.)

In the "Edit Group" dialog I'm wondering if it wouldn't be much more convenient if Enter moved the key to the other list. And I've been pondering the same for double click, by the way.

Agreed, this would be my expectation.

Then what about just adding a new context menu item: "Show Certificate Details" to make it accessible?

ebo triaged this task as Normal priority.Mon, Aug 31, 4:07 PM
ebo removed a project: vsd34.
ikloecker changed the task status from Open to Testing.Tue, Sep 1, 5:13 PM
ikloecker claimed this task.
ikloecker moved this task from Backlog to WIP on the gpd5x board.

Changes:

  • In the Configure Groups dialog:
    • Additionally to double clicking, pressing Enter now opens the Edit Group dialog for the selected group.
  • In the Edit Group dialog:
    • Double clicking and pressing Enter adds/removes the selected groups to/from the group.
    • Details is now available in the context menu of the key lists.

Moreover (because the default context menu for some key lists was extended):

  • In the Imported Certificates dialog:
    • Details is now available in the context menu of the key lists.
ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Sep 7, 9:46 AM