Maniphest T7141

gpgme does not handle backslashes in file names correctly.
Closed, ResolvedPublic
Actions

Assigned To
• ikloecker
Authored By
• werner
Jun 4 2024, 2:37 PM
Tags
Subscribers
• aheinecke
• ikloecker
• werner

Description

In particular UNC (\\SERVER\FILE) style names are problematic in 1.23. As soon as direct passing of filenames to gpg is enabled, the extra quoting done in w32-io.c and gpgme-w32spawn.c is misbehaving. Probably due to the double quotes usage in UNC.

Instead of fixing these nasty double-backslash things and risking other breaks of quoting (again), we should pass forward slashes to gpg. This is well defined for Windows just a bit uncommon for Windows-only users.

See also rM0221d7f28a315d305409cf2dcae853c22ad94d31 and T6833

Revisions and Commits

rM GPGME
rM25dd284b0c42 core,w32: Pass file names with forward slashes to gpg and gpgtar

Related Objects
Search...

Event Timeline

• werner triaged this task as Normal priority.Jun 4 2024, 2:37 PM
• werner created this task.
• werner updated the task description. (Show Details)Jun 4 2024, 2:39 PM
• ebo updated the task description. (Show Details)Jun 4 2024, 3:15 PM
• ikloecker added a commit: rM25dd284b0c42: core,w32: Pass file names with forward slashes to gpg and gpgtar.Jun 4 2024, 5:06 PM
• ikloecker changed the task status from Open to Testing.Jun 7 2024, 3:18 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a project: vsd33.

Adding vsd33 for testing with next VSD

• ikloecker moved this task from Backlog to WiP on the vsd33 board.Jun 7 2024, 3:19 PM
• werner mentioned this in Unknown Object (Maniphest Task).Aug 28 2024, 11:51 AM
• ebo added a project: vsd32 (vsd-3.2.3).Aug 28 2024, 11:55 AM
• ebo closed this task as Resolved.Aug 28 2024, 3:48 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved this task from Backlog to QA for next release on the gpgme board.
• ebo moved this task from WiP to vsd-3.3.0 on the vsd33 board.
• ebo edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
• ikloecker mentioned this in T7395: Prepare Release Notes for Gpg4win 4.4.0 for Kleopatra.Nov 14 2024, 9:23 AM