Maniphest T7008

Kleopatra: New tabs in certficate list should use same column layout as current tab
Closed, ResolvedPublic
Actions

Assigned To
timegrid
Authored By
• ikloecker
Feb 23 2024, 9:17 AM
Tags
Subscribers
• ebo
• ikloecker
timegrid

Description

How to reproduce:

  • In the certificate list click the "Open a new tab" button.
  • Alternatively, import some certificates to get a new tab with the imported certificates.

Actual result:

  • After "Open a new tab" all columns seem to have the default size (100 pixels). (This seems to be caused by an old column layout stored in the configuration. I think the column layout of closed tabs should be removed from the configuration.)
  • After importing the columns seem to have been resized to the contents.

Expected result:

  • A new tab is shown with the same column layout as the previously shown tab.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRA612c7ee8dc0d Mark columns as resized when their sizes are set explicitly

Related Objects

Event Timeline

• ikloecker triaged this task as Normal priority.Feb 23 2024, 9:17 AM
• ikloecker created this task.
• ikloecker added projects: kleopatra, Restricted Project.Feb 23 2024, 10:04 AM
• TobiasFella changed the task status from Open to Testing.Mar 21 2024, 3:32 PM
• TobiasFella claimed this task.
• TobiasFella moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo changed the task status from Testing to Open.Mar 13 2025, 4:44 PM
• ebo edited projects, added gpd5x; removed Restricted Project.
• ebo added a subscriber: • ebo.

5.0Beta-145:

This does not work as expected.
Import tabs still always have the default layout, regarding the width. The columns shown are kept from the previous tab, though.

If you take a regular tab, make some columns smaller, the resulting second tab when you click the "new tab" button, will have the same layout. But when you then import something, not only the import tab has the default width for the columns, now the other "child" tab(s) have the default width too. Only the original tab, which I resized manually, will keep its column widths.

• ikloecker changed the task status from Open to Testing.Jan 13 2026, 10:04 AM

In the meantime we don't show the imported certificates anymore in the main window as tabs but in a separate window, i.e. import tabs are no longer an issue. Please retest.

• ikloecker moved this task from Backlog to QA on the gpd5x board.Jan 13 2026, 10:04 AM
timegrid added a subscriber: timegrid.EditedJan 14 2026, 3:15 PM

In gpg4win-5.0.0-beta479 @ win11

  • I can confirm, that a new tab will inherit the layout from the currently active tab
  • On import
    • The layout of the main tab is kept
    • The import cert table has it's own layout though (default columns/widths) - should this be different? see next comment
timegrid added a comment.Jan 15 2026, 12:29 PM

Correction: On import, the width of the last created tab (not the current one) will be used, but additional columns won't be added.

timegrid added a comment.Jan 15 2026, 12:43 PM

Another correction: I'm quite sure, that changing the width worked for a while (until i created that new tab), but I can't reproduce this anymore (even after deleting kleopatrastaterc). Now the import list again seems to have it's own memory (changing width in the import list will be kept on the next import)

timegrid added a comment.Jan 15 2026, 1:16 PM

Is this is good enough or should the import cert list also inherit the layout (with or without additional columns) from the currently active tab?

• TobiasFella removed • TobiasFella as the assignee of this task.Jan 21 2026, 11:08 AM
• TobiasFella added a subscriber: • TobiasFella.
• ebo added a comment.EditedJan 21 2026, 2:17 PM

I'm fine with the current state in 5.0, I could live with keeping it like that for GPD, i.e. the import list (which will not be used often, anyway) has it's on memory.

But the behavior in the VSD branch (checked wit VSD 3.3.4) has a very different behavior. Although the changes made in this ticket should be in there, too, as they were made before Mai 2024 where QT6 branched of.

In VSD 3.3.4 new tabs are only opened with the same layout as the previous one as long as no certificate is imported. The imported certificate tab always has the default size columns and on import the columns in all tabs to the left of it - except for the very fist one - are resized to the default, too.

What shall we do?

• ebo added a project: vsd34.Jan 21 2026, 4:51 PM

We need to retest this with vsd34 as @ikloecker backported some tab related things after the 3.3.4 release.

• ebo moved this task from Backlog to WIP on the vsd34 board.Jan 21 2026, 4:52 PM
• TobiasFella removed a subscriber: • TobiasFella.Jan 29 2026, 3:41 PM
timegrid moved this task from QA to Done on the gpd5x board.Mar 5 2026, 4:20 PM
timegrid moved this task from WIP to QA on the vsd34 board.Jun 26 2026, 9:58 AM
timegrid changed the task status from Testing to Open.Tue, Aug 25, 9:19 AM
timegrid moved this task from QA to WIP on the vsd34 board.

Tested on vsd-3.4.0-beta1326 @ win10.

Issues found:

  • Import: It works for the first import. on second import, columns are resized again to the contents (for all "Imported Certificates" tabs):
  • New tab:
    • First time works
    • Adding and resizing a column (e.g. Fingerprint), and moving it before Email seems to often (not always) trigger a bug:
      • First the Email column is changing it's order and/or width.
      • If Email is resized, the next column is Status to behave the same
      • If Status is resized, then "Valid from", etc
      • If a former tab is duplicated, it starts with Email again
      • If all columns are resized, the bug seem not to occur
1) first time ok
2) email column moved and resized (needed 3 tries of resizing/moving the fingerprint/protocol column)
3) status column moved and resized
• ikloecker mentioned this in T8415: Kleopatra: Column sizes are reset to default in new tabs when keys are reloaded.Tue, Aug 25, 1:42 PM
• ikloecker added a comment.Tue, Aug 25, 1:45 PM

I found an easier way to reproduce the issue. It also happens in Gpg4win 5. I created T8415: Kleopatra: Column sizes are reset to default in new tabs when keys are reloaded to better track the issue.

• ikloecker added a commit: rKLEOPATRA612c7ee8dc0d: Mark columns as resized when their sizes are set explicitly.Tue, Aug 25, 1:55 PM
• ikloecker changed the task status from Open to Testing.Tue, Aug 25, 1:57 PM

The issue is fixed.

timegrid closed this task as Resolved.Fri, Aug 28, 12:01 PM
timegrid claimed this task.

Looks good to me on vsd-3.4.0-beta1344 @ win10.

timegrid moved this task from WIP to vsd-3.4.0 on the vsd34 board.Fri, Aug 28, 12:01 PM
timegrid edited projects, added vsd34 (vsd-3.4.0); removed vsd34.