kleo: Use pkg-config to determine libassuan use
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• gniibe
	Dec 14 2022, 7:00 AM

Description

kleopatra uses libassuan-config.

Revisions and Commits

rKLEOPATRA Kleopatra
	rKLEOPATRA8eba66693778 Provide and use imported target LibGpgError::LibGpgError
	rKLEOPATRA71a77f8804dc Remove obsolete compatibility typedef assuan_error_t
	rKLEOPATRA3ed24fe5eb37 Provide and use imported target LibAssuan::LibAssuan
	rKLEOPATRA2d6daefce6ba Add FindLibGpgError.cmake to find Libgpg-error
	rKLEOPATRA15496394c26a Remove the obsolete kleo-assuan.h compatibility header
	rKLEOPATRAad23c4192457 Remove more superfluous configure checks for assuan
	rKLEOPATRAa17fc1b29d7c Replace FindAssuan2.cmake with a rewrite
	rKLEOPATRAe67bdaf57712 Remove useless BUILD_libkleopatraclient option
	rKLEOPATRA023c176ee90b Remove long unsupported "support" for assuan 1
	rKLEOPATRA41574f7beb36 Remove obsolete define _ASSUAN_ONLY_GPG_ERRORS
	rKLEOPATRA9375c90015e1 Provide and use imported target LibGpgError::LibGpgError
	rKLEOPATRAe3df59f4f1da Provide and use imported target LibAssuan::LibAssuan
	rKLEOPATRA0b428a8e7b54 Provide and use imported target LibGpgError::LibGpgError
	rKLEOPATRAb40bae967e72 Provide and use imported target LibAssuan::LibAssuan
	rKLEOPATRAce12274478e3 Remove obsolete compatibility typedef assuan_error_t
	rKLEOPATRA669a78919e61 Add FindLibGpgError.cmake to find Libgpg-error
	rKLEOPATRAa986eb598f9e Remove the obsolete kleo-assuan.h compatibility header
	rKLEOPATRA5159385e6ccd Replace FindAssuan2.cmake with a rewrite
	rKLEOPATRAc23a23de9c78 Remove obsolete compatibility typedef assuan_error_t
	rKLEOPATRA403136c6ca95 Remove the obsolete kleo-assuan.h compatibility header
	rKLEOPATRAcb0c6af66333 Add FindGpgError.cmake to find gpg-error
	rKLEOPATRAa39666d558d6 Remove more superfluous configure checks for assuan
	rKLEOPATRA222d138663d3 Replace FindAssuan2.cmake with a rewrite
	rKLEOPATRA5396c02cf64c Remove useless BUILD_libkleopatraclient option
	rKLEOPATRA560ce80d5db7 Remove long unsupported "support" for assuan 1
	rKLEOPATRA5d924ca4b74a Remove obsolete define _ASSUAN_ONLY_GPG_ERRORS
	rKLEOPATRA5eedd9d95c29 Remove obsolete compatibility typedef assuan_error_t
	rKLEOPATRA85250e62389a Remove the obsolete kleo-assuan.h compatibility header
	rKLEOPATRA7283131605b3 Add FindGpgError.cmake to find gpg-error
	rKLEOPATRA18feab458f62 Remove more superfluous configure checks for assuan
	rKLEOPATRA8a10d99a4b58 Replace FindAssuan2.cmake with a rewrite
	rKLEOPATRAec807169cc8e Remove useless BUILD_libkleopatraclient option
	rKLEOPATRA62992621f1ca Remove long unsupported "support" for assuan 1
	rKLEOPATRAd93cfc385dbf Remove obsolete define _ASSUAN_ONLY_GPG_ERRORS

Related Objects

Mentioned In: T6320: gnupg-2.4.0: make check fails

Event Timeline

Here is my try:

0001-build-Use-pkg-config-instead-of-libassuan-config.patch2 KBDownload

Please replace this by proper use of pkg-config of cmake.

Here is my try of next, after 0001.

0002-build-Use-pkg-config-to-find-libassuan-and-libgpg-er.patch19 KBDownload

Thanks for the patches. I have completely rewritten FindAssuan2.cmake and have added a separate FindGpgError.cmake. We cannot assume that pkg-config is available everywhere. Therefore, we cannot use pkg_check_modules exclusively. I have verified that the Find*.cmake files work for gpg4win and for the AppImage.

• ikloecker added a commit: rKLEOPATRAd93cfc385dbf: Remove obsolete define _ASSUAN_ONLY_GPG_ERRORS.Dec 19 2022, 8:03 AM

• ikloecker added a commit: rKLEOPATRA62992621f1ca: Remove long unsupported "support" for assuan 1.

• ikloecker added a commit: rKLEOPATRAec807169cc8e: Remove useless BUILD_libkleopatraclient option.

• ikloecker added a commit: rKLEOPATRA18feab458f62: Remove more superfluous configure checks for assuan.

• ikloecker added a commit: rKLEOPATRA8a10d99a4b58: Replace FindAssuan2.cmake with a rewrite.

• ikloecker added a commit: rKLEOPATRA7283131605b3: Add FindGpgError.cmake to find gpg-error.

• ikloecker added a commit: rKLEOPATRA85250e62389a: Remove the obsolete kleo-assuan.h compatibility header.

• ikloecker added a commit: rKLEOPATRA5eedd9d95c29: Remove obsolete compatibility typedef assuan_error_t.

• ikloecker added a project: Restricted Project.Dec 19 2022, 8:06 AM

• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

• ikloecker added a commit: rKLEOPATRA5d924ca4b74a: Remove obsolete define _ASSUAN_ONLY_GPG_ERRORS.Dec 19 2022, 9:20 AM

• ikloecker added a commit: rKLEOPATRA560ce80d5db7: Remove long unsupported "support" for assuan 1.