Maniphest T5906

gpgme cpp/qt: Only export symbols that are part of the ABI
Closed, ResolvedPublic
Actions

Assigned To
• ikloecker
Authored By
• ikloecker
Mar 28 2022, 4:57 PM
Tags
Subscribers
• ikloecker

Description

The C++ bindings and the Qt bindings of gpgme currently export more symbols than necessary. Symbols that are only used internally shouldn't be exported.

Revisions and Commits

rGPGMEPP Gpgme plus plus
rGPGMEPP6b164183ccf1 cpp: Put local helper function into unnamed namespace
rGPGMEPP0d77fecdc2f1 cpp: Set default visibility of all symbols to hidden
rM GPGME
rM7317139ef9eb doc: Update NEWS
rM3b3b36a60749 qt: Set default visibility of all symbols to hidden
rMfe588fef0963 cpp: Set default visibility of all symbols to hidden
rM92139e7b6b5f cpp: Put local helper function into unnamed namespace

Related Objects

Event Timeline

• ikloecker triaged this task as Normal priority.Mar 28 2022, 4:57 PM
• ikloecker created this task.
• ikloecker closed this task as Resolved.Mar 28 2022, 5:28 PM
• ikloecker added a comment.Mar 28 2022, 5:35 PM

Summary of abidiff for libgpgmepp:

Functions changes summary: 6 Removed (20 filtered out), 0 Changed, 0 Added functions
Variables changes summary: 2 Removed, 0 Changed, 0 Added variables
Function symbols changes summary: 0 Removed, 0 Added function symbol not referenced by debug info
Variable symbols changes summary: 12 Removed, 0 Added variable symbols not referenced by debug info

Summary of abidiff for libqgpgme:

Functions changes summary: 384 Removed (335 filtered out), 0 Changed (13 filtered out), 0 Added functions
Variables changes summary: 32 Removed, 0 Changed, 0 Added variables
Function symbols changes summary: 204 Removed, 0 Added function symbols not referenced by debug info
Variable symbols changes summary: 346 Removed, 0 Added variable symbols not referenced by debug info
• ikloecker added a commit: rM3b3b36a60749: qt: Set default visibility of all symbols to hidden.Mar 28 2022, 5:57 PM
• ikloecker added a commit: rM92139e7b6b5f: cpp: Put local helper function into unnamed namespace.
• ikloecker added a commit: rMfe588fef0963: cpp: Set default visibility of all symbols to hidden.
• ikloecker added a commit: rM7317139ef9eb: doc: Update NEWS.Mar 31 2022, 6:56 PM
• werner mentioned this in T6128: Release GPGME 1.18.0.Aug 10 2022, 4:00 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 24 2023, 2:12 PM
• ikloecker added a commit: rGPGMEPP0d77fecdc2f1: cpp: Set default visibility of all symbols to hidden.Jan 27 2025, 10:36 AM
• ikloecker added a commit: rGPGMEPP6b164183ccf1: cpp: Put local helper function into unnamed namespace.