Maniphest T5898

Two fixes for the gnupg-2.3.4 test suite when running on MS-Windows
Closed, ResolvedPublic
Actions

Assigned To
• gniibe
Authored By
eliz
Mar 21 2022, 7:20 PM
Tags
Subscribers
eliz
• gniibe

Description

The attached patches solve 2 failures when running the gnupg-2.3.4 test suite on MS-Windows:

  • failure in test_close_all_fds due to the fact that close_all_fds is a no-op on Windows
  • t-stringhelp test which fails because it compares file names as simple strings, which doesn't account for the forward slashes vs backslashes in Windows file names.

DIFFS51 KBDownload

Related Objects

Event Timeline

eliz created this task.Mar 21 2022, 7:20 PM
• werner added projects: gnupg (gpg23), Windows.Mar 22 2022, 7:45 AM
• werner triaged this task as Normal priority.Mar 25 2022, 1:28 PM
• gniibe closed this task as Resolved.Sep 1 2022, 3:26 AM
• gniibe claimed this task.
• gniibe added a subscriber: • gniibe.

Thank you for reporting, and sorry for late handling of this report.

These problem has gone in GnuPG 2.3.5, as we have rG39d478f5ba5d: w32: Fix for make check.:

  • t-exechelp is only for !HAVE_W32_SYSTEM
  • t-stringhelp.c was fixed by fixing mygetcwd function.