Maniphest T5892

t-cms-parser test program in libksba-1.6.0 needs to open files in binary mode for MS-Windows
Closed, ResolvedPublic
Actions

Assigned To
• gniibe
Authored By
eliz
Mar 21 2022, 6:52 PM
Tags
Subscribers
eliz
• gniibe

Description

The one_file function in the t-cms-parser.c file from the libksba-1.6.0 test suite opens binary files, but doesn't use rb in the fopen call.
This causes the tests to fail on MS-Windows.
Attached please find a patch for that.

DIFFS372 BDownload

Event Timeline

eliz created this task.Mar 21 2022, 6:52 PM
• gniibe changed the task status from Open to Testing.Mar 22 2022, 3:21 AM
• gniibe added a project: libksba.
• gniibe added a subscriber: • gniibe.

Thank you. Confirmed and applied.

• gniibe triaged this task as Normal priority.Mar 22 2022, 3:22 AM
• gniibe added a project: Restricted Project.Mar 25 2022, 6:17 AM
• werner removed a project: Restricted Project.Sep 22 2022, 11:04 AM
• gniibe closed this task as Resolved.Oct 11 2022, 8:23 AM
• gniibe claimed this task.

Fixed in 1.6.1.