Maniphest T5288

Kleopatra: Check that KeyCache::findBestByMailBox is in sync with GnuPG and maybe move it
Closed, ResolvedPublic
Actions

Assigned To
• aheinecke
Authored By
• aheinecke
Feb 8 2021, 11:26 AM
Tags
Subscribers
• aheinecke
• ikloecker

Description

Last week there were changes / fixes to GnuPG's get_best_pubkey_by_name (not sure if that is the exact function name). This is the code gnupg uses when you do a

gpg -er aheinecke@gnupg.org

to find the best key to encrypt to.

Or which key gpg --locate-key aheinecke@gnupg.org would return.

They are defined by checking for a single mailbox.
We have mirrored code in libkleo with KeyCache::findBestByMailBox . Which was a crutch at the time as I didn't know where to better place it. I would rather have some key comparison in GpgME++ and then use it to basically only sort in Libkleo's keycache. But I didn't know how to then also add group support so I did it in the Keycache.

I'm using the function in the newkeyresolver in libkleo and by extension in GpgOL.

This deserves at least a look to check what has been changed in GnuPG.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO837f48ec5068 Match the logic of GnuPG's pubkey_cmp() as closely as possible
rLIBKLEO56fa4d79d01d Support lookup of email addresses enclosed in angle brackets
rLIBKLEOc5ca839c6acb Fix check for newer key when looking for best key for an email address

Related Objects

Event Timeline

• aheinecke created this task.Feb 8 2021, 11:26 AM
• ikloecker added a comment.Feb 25 2021, 10:23 AM

Notes to self:

• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Feb 25 2021, 10:25 AM
• ikloecker added a commit: rLIBKLEO56fa4d79d01d: Support lookup of email addresses enclosed in angle brackets.Feb 26 2021, 12:26 PM
• ikloecker added a commit: rLIBKLEOc5ca839c6acb: Fix check for newer key when looking for best key for an email address.
• ikloecker added a commit: rLIBKLEO837f48ec5068: Match the logic of GnuPG's pubkey_cmp() as closely as possible.Mar 2 2021, 8:57 AM
• ikloecker changed the task status from Open to Testing.Mar 2 2021, 9:03 AM
• ikloecker reassigned this task from • ikloecker to • aheinecke.
• ikloecker added a subscriber: • ikloecker.

Please test this with the Outlook plugin. It doesn't seem to be used elsewhere.

• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Mar 2 2021, 9:04 AM
• ikloecker closed this task as Resolved.Oct 20 2021, 4:28 PM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 20 2021, 4:39 PM