Maniphest T4529

libgcrypt: POWER AES Vector Acceleration
Closed, ResolvedPublic
Actions

Assigned To
jukivili
Authored By
gcwilson
May 20 2019, 7:01 PM
Tags
Subscribers
gcwilson
johnmar
jukivili
raksprak
slandden
• werner

Description

Use POWER8 and POWER9 ISA enhancements to improve the performance of AES. Demonstrate why achieved performance is close to optimal for the platform. Optimized implementations in the Cryptogams repository[1] may serve as useful references. Financial bounty upon completion and community acceptance of patches.

https://github.com/dot-asm/cryptogams/

Revisions and Commits

AbandonedD490 PowerPC optimized routines for AES and SHA2 using PowerISA 2.07 instructions.
Needs ReviewD493 AES block modes for PPC
AbandonedD491 Support for PowerPC's AES acceleration.
rC libgcrypt
Needs ReviewD494 rijndael/ppc: re-implement single-block mode, and implement OCB block cipher
rC81d555d34730 rijndael-ppc: add bulk modes for CBC, CFB, CTR and XTS
rC821602c60c7d rijndael-ppc: enable PowerPC AES-OCB implemention
rCbd1367bb6078 rijndael-ppc: add bulk mode for ocb_auth
rC9dca65ef71b4 rijndael-ppc: add key setup and enable single block PowerPC AES
rC92f38a619b1c rijndael/ppc: implement single-block mode, and implement OCB block cipher
rCb4a3c76fabfa hwf: add detection of PowerPC hardware features

Related Objects
Search...

Event Timeline

gcwilson created this task.May 20 2019, 7:01 PM
slandden added a subscriber: slandden.May 20 2019, 8:35 PM

Would the maintainers accept having perl in the repository? Linux does it.[1]

[1] https://github.com/torvalds/linux/blob/master/drivers/crypto/vmx/ghashp8-ppc.pl

gcwilson added a comment.May 20 2019, 9:46 PM

I don't know. That would make it a relatively easy transplant. We've also used the Cryptogams code as a reference for Golang enhancements, if that helps. I'd welcome guidance on the matter from a maintainer.

slandden added a comment.May 20 2019, 11:52 PM

I'm looking into doing a pretty epic hack of using the switch_endian syscall to speed this up.

• werner renamed this task from [$] libgcrypt: POWER AES Vector Acceleration to libgcrypt: POWER AES Vector Acceleration.May 21 2019, 7:47 AM
• werner triaged this task as Normal priority.May 21 2019, 7:51 AM
• werner added a subscriber: • werner.

Perl would be okay for maintainer mode but not for regular builds. The reason is that perl is already used by autotools but a build shall still be possible w/o perl.

• werner added a parent task: T4531: PowerPC performance improvements.May 21 2019, 7:54 AM
slandden added a revision: D491: Support for PowerPC's AES acceleration..May 24 2019, 6:03 AM
slandden mentioned this in D493: AES block modes for PPC.Jun 3 2019, 5:38 AM
raksprak added a subscriber: raksprak.Jun 18 2019, 12:20 PM
jukivili added revisions: D493: AES block modes for PPC, D494: rijndael/ppc: re-implement single-block mode, and implement OCB block cipher.Jul 8 2019, 2:55 PM
jukivili added a revision: D490: PowerPC optimized routines for AES and SHA2 using PowerISA 2.07 instructions..
johnmar added a subscriber: johnmar.Jul 9 2019, 10:11 PM
johnmar raised the priority of this task from Normal to Needs Triage.Jul 15 2019, 9:09 PM
• werner triaged this task as Normal priority.Jul 16 2019, 8:33 AM

Please do not change the priority back. That is a maintainer's task. I consider this along with adding replicas of issues to a bit rude.

jukivili claimed this task.EditedAug 25 2019, 6:10 PM
jukivili added a subscriber: jukivili.

Patches for PowerPC AES acceleration sent to mailing-list, based partly on initial work by Shawn Landden (@slandden): https://lists.gnupg.org/pipermail/gcrypt-devel/2019-August/004788.html

Because there was license concerns with Cryptogams code (https://lists.gnupg.org/pipermail/gcrypt-devel/2019-July/004774.html), I decided to implemented missing parts for this myself.

jukivili added a commit: rCb4a3c76fabfa: hwf: add detection of PowerPC hardware features.Aug 26 2019, 7:04 PM
jukivili added a commit: rC92f38a619b1c: rijndael/ppc: implement single-block mode, and implement OCB block cipher.
jukivili added a commit: rC9dca65ef71b4: rijndael-ppc: add key setup and enable single block PowerPC AES.
jukivili added a commit: rCbd1367bb6078: rijndael-ppc: add bulk mode for ocb_auth.
jukivili added a commit: rC81d555d34730: rijndael-ppc: add bulk modes for CBC, CFB, CTR and XTS.
jukivili added a commit: rC821602c60c7d: rijndael-ppc: enable PowerPC AES-OCB implemention.
jukivili closed this task as Resolved.Aug 31 2019, 1:38 AM
• werner mentioned this in T4294: Release Libgcrypt 1.9.0.Jan 19 2021, 10:17 AM