Maniphest T4113

GpgOL, Performance: Cache icons for RibbonUI
Closed, ResolvedPublic
Actions

Assigned To
• aheinecke
Authored By
• aheinecke
Aug 28 2018, 5:54 PM
Tags
Subscribers
• aheinecke

Description

GpgOL should cache the icons returned to the Ribbon UI instead of instantiating a new GDIPlus instance and converting it from PNG to bitmap dispatcher for each call.

Details

Version
master

Revisions and Commits

rO GpgOL
rO4c573f3c8984 Cache icons

Related Objects
Search...

Event Timeline

• aheinecke created this task.Aug 28 2018, 5:54 PM
• aheinecke added a commit: rO4c573f3c8984: Cache icons.Aug 29 2018, 11:30 AM
• aheinecke added a subtask: T4029: Gpg4win 3.1.3.Aug 29 2018, 11:38 AM
• aheinecke closed this task as Resolved.Aug 30 2018, 7:57 AM

This is done now.
I had a slight hope that this might help with random crashes as the COM is now under less load but it did not help.

Anyway caching the icons is a good thing anyway.

• aheinecke closed subtask T4029: Gpg4win 3.1.3 as Resolved.Sep 4 2018, 9:24 AM