Maniphest T8018

Okular: No error on signature with wrong passphrase
Closed, ResolvedPublic
Actions

Assigned To
timegrid
Authored By
timegrid
Jan 6 2026, 2:28 PM
Tags
Subscribers
• ebo
svuorela
timegrid

Description

Found by testing T7285: Okular: Improvement of error messages regarding signatures

To reproduce:

  1. Kill gpg agent to make sure, there's no session open
  2. Open and save a (smime or pgp) signed pdf file
  3. Enter a wrong passphrase in pinentry 3 times ->
    • there's no error message
    • okular still shows "finish signing":
    • the file was written but has a broken signature:
      test_signed_11.pdf29 KBDownload

Details

Version
gpg4win-5.0.0-beta479 @ win11

Related Objects

Event Timeline

timegrid created this task.Jan 6 2026, 2:28 PM
timegrid created this object with edit policy "Contributor (Project)".
timegrid mentioned this in T7285: Okular: Improvement of error messages regarding signatures.Jan 6 2026, 2:33 PM
• werner triaged this task as Normal priority.Jan 7 2026, 12:04 PM
• werner added a project: Bug Report.
svuorela changed the task status from Open to Testing.Jan 13 2026, 2:36 PM

Fixed upstream with https://invent.kde.org/graphics/okular/-/merge_requests/1301 - not yet in our packaging

• ebo moved this task from Backlog to WIP on the gpd5x board.Jan 13 2026, 4:16 PM
• ebo added a project: test on hold.Feb 26 2026, 4:24 PM
svuorela moved this task from WIP to QA on the gpd5x board.Tue, Jul 7, 3:13 PM
svuorela removed a project: test on hold.
timegrid closed this task as Resolved.Wed, Jul 8, 1:37 PM
timegrid claimed this task.

Looks not pretty, but good to me on gpg4win-5.1.0-beta653 @ win11:

Note:

  • The duplicated Bad passphrase feedback hidden behind the collapsed Details is not exactly user friendly. It would be better to hide the Details in cases, in which they are not helpful (I'll create another low/wishlist prio ticket for that)
timegrid moved this task from QA to gpd-5.1.0 on the gpd5x board.Wed, Jul 8, 1:38 PM
timegrid edited projects, added gpd5x (gpd-5.1.0); removed gpd5x.
• ebo added a comment.EditedWed, Jul 8, 1:46 PM

seems to me, that the details here are no details and could be dropped completely. I'm i overlooking something?
And wouldn't "Could not sign: Wrong passphrase" be better? Or even better: "Signature failed: Wrong passphrase"?
In Kleopatra we have: "Signing failed: %1"

timegrid added a comment.Wed, Jul 8, 2:00 PM
In T8018#219988, @ebo wrote:

seems to me, that the details here are no details and could be dropped completely.

With "hide" i meant removing it, so i agree

svuorela added a comment.Wed, Jul 8, 2:04 PM
In T8018#219988, @ebo wrote:

seems to me, that the details here are no details and could be dropped completely. I'm i overlooking something?
And wouldn't "Could not sign: Wrong passphrase" be better? Or even better: "Signature failed: Wrong passphrase"?
In Kleopatra we have: "Signing failed: %1"

the "Details" is the message we get out of gpg as the error. First part of the message is something we maybe better can control.

I guess we can special case the bad passphrase a bit further.

svuorela added a comment.Wed, Jul 8, 4:23 PM

whattabout https://invent.kde.org/graphics/okular/-/merge_requests/1404 ?

timegrid added a comment.Wed, Jul 8, 4:37 PM
In T8018#220049, @svuorela wrote:

whattabout https://invent.kde.org/graphics/okular/-/merge_requests/1404 ?

Would be fine for me

timegrid mentioned this in T8341: Okular: Hide details on bad passphrase error dialog.Thu, Jul 9, 3:59 PM
timegrid added a comment.Thu, Jul 9, 4:43 PM
In T8018#220049, @svuorela wrote:

whattabout https://invent.kde.org/graphics/okular/-/merge_requests/1404 ?

Issue split into T8341: Okular: Hide details on bad passphrase error dialog